[Webkit-unassigned] [Bug 77886] KeywordLookupGenerator.py script fails in some cases
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 11 14:05:23 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=77886
Benjamin Poulain <benjamin at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #126629|review? |review+, commit-queue-
Flag| |
--- Comment #12 from Benjamin Poulain <benjamin at webkit.org> 2012-02-11 14:05:22 PST ---
(From update of attachment 126629)
View in context: https://bugs.webkit.org/attachment.cgi?id=126629&action=review
Some nitpicking:
> Source/JavaScriptCore/ChangeLog:12
> + Keywords.table has been converted to LF-only.
> +
> + * parser/Keywords.table:
The line "* parser/Keywords.table:" is made for the comments about that file. You should have:
* parser/Keywords.table: Converted to LF-only.
> Source/JavaScriptCore/parser/Keywords.table:38
> -# reserved for future use
> +# reserved for future use.
Our rule is "Make comments look like sentences by starting with a capital letter and ending with a period (punctation)."
If you fix the period, you should fix the capital letter :)
> Source/JavaScriptCore/parser/Keywords.table:49
> -# reserved for future use in strict code
> +# reserved for future use in strict code.
ditto
> Tools/ChangeLog:10
> + Keywords.table has been converted to LF-only.
This should not be part of this particular ChangeLog.
> Tools/Scripts/webkitpy/style/checker.py:243
> + # This is only critical for the first and last lines
> + # which are compared verbatim.
This is describing an implementation detail in an other script, it is a bad idea to have that in a comment. You can drop those lines.
> Tools/Scripts/webkitpy/style/checker_unittest.py:273
> + path = "Source/JavaScriptCore/parser/Keywords.table"
> + assertCheck(path, "whitespace/carriage_return")
No need for the variable "path", follow the style of this function passing strings as literal.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list