[Webkit-unassigned] [Bug 27160] Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27160





--- Comment #33 from Antti Koivisto <koivisto at iki.fi>  2012-02-11 12:20:22 PST ---
(From update of attachment 126385)
View in context: https://bugs.webkit.org/attachment.cgi?id=126385&action=review

Someone more familiar with these standard should review (smfr, hyatt?).

> Source/WebCore/css/CSSStyleSelector.cpp:2433
> -static Length convertToLength(CSSPrimitiveValue* primitiveValue, RenderStyle* style, RenderStyle* rootStyle, bool toFloat, double multiplier = 1, bool *ok = 0)
> +static Length convertToLength(CSSPrimitiveValue* primitiveValue, CSSStyleSelector* styleSelector, bool toFloat, double multiplier = 1, bool *ok = 0)

I don't like passing CSSStyleSelector*. Just try passing the minimal information you actually need for this (viewport?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.