[Webkit-unassigned] [Bug 27880] HTML 5: Support click() method on HTMLElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 11 01:38:28 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=27880





--- Comment #13 from Arko Saha <nghq36 at motorola.com>  2012-02-11 01:38:27 PST ---
Thanks Eric for the review.

(In reply to comment #12)
> (From update of attachment 126624 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126624&action=review
> 
> > Source/WebCore/bindings/objc/PublicDOMInterfaces.h:421
> > +- (void)click AVAILABLE_WEBKIT_VERSION_3_0_AND_LATER_BUT_DEPRECATED_AFTER_WEBKIT_VERSION_5_1;
> 
> Are you sure you have to do this this way?  I doubt that any Obj-c program cares if -click is exposed on these subclasses or on the baseclass. Since you're adding it to HTMLElement, things should "just work" and I would expect we could remove this w/o deprecation warnings.

Ok, so if we keep the -click in HTMLButtonElement and HTMLInputElement with old macro will it work on mac? Do we need to keep the method under LANGUAGE_OBJECTIVE_C in .idl files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list