[Webkit-unassigned] [Bug 78404] [chromium] Replace RefPtr with OwnPtr for CCLayerImpl tree structure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 10 20:54:03 PST 2012


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #126614|review?                     |review-
               Flag|                            |

--- Comment #2 from James Robinson <jamesr at chromium.org>  2012-02-10 20:54:03 PST ---
(From update of attachment 126614)
View in context: https://bugs.webkit.org/attachment.cgi?id=126614&action=review

I like everything except the TreeSynchronizer change.  TreeSynchronizer shouldn't be instantiable, it should just be pure functions.

> Source/WebCore/platform/graphics/chromium/TreeSynchronizer.h:51
> +    TreeSynchronizer() { }

why did you change this? i much prefer having tree syncing be a pure function, this is weird

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list