[Webkit-unassigned] [Bug 78364] [GTK] Revise configuration for WebGL & MHTML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78364


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-02-10 12:24:40 PST ---
(In reply to comment #2)

> > configure.ac:540
> > -# check whether to enable WebGL support
> > -AC_MSG_CHECKING([whether to enable WebGL support])
> > -AC_ARG_ENABLE(webgl,
> > -              AC_HELP_STRING([--enable-webgl], [enable support for WebGL [default=yes]]),
> > -              [], [if test "$with_target" = "x11"; then enable_webgl="yes"; else enable_webgl="no"; fi])
> > -AC_MSG_RESULT([$enable_webgl])
> > +# check whether to enable 3D canvas (WebGL) support
> > +AC_MSG_CHECKING([whether to enable 3D canvas (WebGL) support])
> > +AC_ARG_ENABLE(3d-canvas,
> > +              AC_HELP_STRING([--enable-3d-canvas], [enable support for 3D canvas (WebGL) [default=yes]]),
> > +              [], [if test "$with_target" = "x11"; then enable_3d_canvas="yes"; else enable_3d_canvas="no"; fi])
> > +AC_MSG_RESULT([$enable_3d_canvas])
> 
> This is intended. You can give --enable-webgl to build-webkit, and the option will be forwarded. We do not need to follow build-webkit's naming on our names =)

I agree. The names exposed in configure.ac are for people compiling WebKitGTK+ from a tarball. "3D canvas" is a name particular to WebKit, while "WebGL" is more well-known. if the arguments to build-webkit are not properly mapped to configure arguments that's another sort of bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.