[Webkit-unassigned] [Bug 77557] Introduce a flag to denote layers which should follow the page scale

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77557


Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #126544|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com>  2012-02-10 12:22:47 PST ---
(From update of attachment 126544)
View in context: https://bugs.webkit.org/attachment.cgi?id=126544&action=review

r- because of the added ambiguity.

> Source/WebCore/ChangeLog:9
> +          1. Layer contents are scaled by the painter (e.g., non-composited
> +             content layer)

"the painter" is not a term we use in WebKit. I don't really know what you mean by it.

> Source/WebCore/ChangeLog:37
> +        Reviewed by NOBODY (OOPS!).

This should go above the description.

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:86
> +    , m_needsPageScale(true)

Currently layers which are descendants of the layer with m_appliesPageScale=true get scaled. Put another way, the layer with m_appliesPageScale=true is the root of the scale.

Now that you've added m_needsPageScale, there is ambiguity. What does it mean for a layer which is ancestral to the m_appliesPageScale=true layer to have m_needsPageScale=true?

Maybe we should pull out m_appliesPageScale entirely, and have RLC store which layer is the scale root. Instead of m_needsPageScale, you could then have m_ignoresPageScale, which is set to true for overflow control layers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.