[Webkit-unassigned] [Bug 77951] Chrome crashes when attempting to add cue to track element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77951





--- Comment #7 from Eric Carlson <eric.carlson at apple.com>  2012-02-10 11:20:11 PST ---
(From update of attachment 126469)
View in context: https://bugs.webkit.org/attachment.cgi?id=126469&action=review

> Source/WebCore/html/TextTrack.cpp:159
> +    ASSERT(m_cues);

This is unnecessary. Because the list is allocated in the constructor, the only way for this to assert is if the allocation fails. The previous check was because the list was not allocated until it was used.

> Source/WebCore/html/TextTrack.cpp:173
> +    ASSERT(m_cues);

Ditto.

> Source/WebCore/html/TextTrack.cpp:188
> +    ASSERT(m_cues);

Ditto.

> Source/WebCore/html/TextTrack.cpp:226
> +    ASSERT(m_cues);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.