[Webkit-unassigned] [Bug 78257] Use underlying property set to refcount PropertySetCSSStyleDeclaration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78257





--- Comment #11 from Andreas Kling <kling at webkit.org>  2012-02-10 01:19:38 PST ---
(From update of attachment 126444)
View in context: https://bugs.webkit.org/attachment.cgi?id=126444&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.h:48
> +class CSSComputedStyleDeclaration : public CSSStyleDeclaration, private WTF::RefCountedBase {

Why do we need to inherit from RefCountedBase here?
Shadowing ref() and deref() in RefCountedBase with overridden virtuals from CSSStyleDeclaration is a little confusing and the ChangeLog doesn't explain what's going on.

> Source/WebCore/css/StylePropertySet.cpp:50
> +    PropertySetCSSStyleDeclaration(StylePropertySet* propertySet) : m_propertySet(propertySet) { }

explicit PropertySetCSSStyleDeclaration(StylePropertySet* propertySet) : m_propertySet(propertySet) { }
Because you're worth it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.