[Webkit-unassigned] [Bug 63062] Add capture attribute for HTML Media Capture

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63062





--- Comment #27 from Jongseok Yang <js45.yang at samsung.com>  2012-02-10 00:32:17 PST ---
(In reply to comment #26)
> Thanks for the new patch Jongseok. I'm not a reviewer, but FWIW I don't think the patch addresses the previous review comments.
> 
> I think it'd be best to follow the previous review advice and create a new Capture chooser that inherits from FileChooser and adds the capture attribute value.
> 
> Then add a new method on Chrome[Client] to start a capture panel passing in the capture attribute - it can be called from FileInputType at the same place runOpenPanel is called - we determine which one to call based on whether a capture attribute is set or not. Then each port can handle the runCapturePanel as they see fit (which may be very similar to what they do in runOpenPanel, but might not too).
> 
> What do you think?


Thanks for your review. 
I have implemented it to accept you. I'll upload new patch next week after making up for the week points.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.