[Webkit-unassigned] [Bug 71262] Web Inspector: Add colorpicker functionality to color swatches in Styles Sidebar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71262





--- Comment #42 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-02-09 22:48:41 PST ---
(From update of attachment 126438)
View in context: https://bugs.webkit.org/attachment.cgi?id=126438&action=review

The patch looks good in general. My only concern is that you cannot cancel the colorpicker (without applying the selected color to the current property.) Please fix the nits and let us play around with it to see if there are any critical issues that should definitely be fixed before landing.

> Source/WebCore/inspector/front-end/Spectrum.js:282
> +            // Everything except HSL(A) should returned as RGBA if transparency is involved.

typo: ...should be returned...

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1667
> +                             spectrum.addEventListener(WebInspector.Spectrum.Events.ColorChanged, spectrumChange);

Shouldn't we remove the listeners when the spectrum gets hidden?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.