[Webkit-unassigned] [Bug 77930] INPUT shouldn't create ShadowRoot dynamically.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 9 21:05:52 PST 2012


--- Comment #5 from Dominic Cooney <dominicc at chromium.org>  2012-02-09 21:05:52 PST ---
(From update of attachment 126420)
View in context: https://bugs.webkit.org/attachment.cgi?id=126420&action=review

> Source/WebCore/ChangeLog:12
> +        Media control elements are implemented input elements. These elements should also

The meaning of "Media control elements are implemented input elements" is not clear to me.

> Source/WebCore/html/FileInputType.cpp:270
> +    element()->shadowRoot()->appendChild(element()->multiple() ? UploadButtonElement::createForMultiple(element()->document()): UploadButtonElement::create(element()->document()), ec);

Won’t this be problematic if I attach an author shadow root to the input element? Then the UploadButtonElement will be leaked into my author shadow root.

> Source/WebCore/html/InputType.cpp:382
> +        while (root->hasChildNodes())

What about root->removeAllChildren() or root->removeChildren()

*I’m not sure which one of these you want. Probably removeChildren.*

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list