[Webkit-unassigned] [Bug 54623] RTL web content should have left-hand scrollbar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54623


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125303|review?                     |review+
               Flag|                            |




--- Comment #51 from Eric Seidel <eric at webkit.org>  2012-02-09 10:48:09 PST ---
(From update of attachment 125303)
View in context: https://bugs.webkit.org/attachment.cgi?id=125303&action=review

This code looks right to me.  I think you could have simplified the #defines by moving them as noted below, but I also think this i OK.  Thank you for hte patch.

> Source/WebCore/rendering/RenderLayer.cpp:1831
> +    return IntRect(cornerStart(layer, bounds.x(), bounds.maxX(), horizontalThickness),

I'm not sure what you mean by "corner start" here?

> Source/WebCore/rendering/style/RenderStyle.h:966
> +    bool shouldPlaceBlockDirectionScrollbarOnLogicalLeft() const { return !isLeftToRightDirection() && isHorizontalWritingMode(); }

It seems it would have been simpler to put the #if around this function, and just define a version of thsi function which only returns false when RTL_SCROLLBAR is disabled.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.