[Webkit-unassigned] [Bug 77337] [EFL] Refactor ewk_js files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77337





--- Comment #10 from Raphael Kubo da Costa <kubo at profusion.mobi>  2012-02-09 07:00:39 PST ---
(In reply to comment #9)
> BTW I don't know why EFL port don't follow this rule and put every thing into ewk_private.h file?

Mostly because that's what the EFL themselves do.

> a) For example instead of direct creating and managing of js meta class object I am suggesting to add few new API functions to manage it indirectly. I would like to introduce these function:
> 
> ewk_js_meta_class_new()
> ewk_js_meta_class_free(Ewk_JS_Class_Meta *meta_cls)
> ewk_js_meta_class_method_add(Ewk_JS_Class_Meta *meta_cls, const char *name, Ewk_JS_Invoke_Cb);
> ewk_js_meta_class_property_add(Ewk_JS_Class_Meta *meta_cls, const char *name, Ewk_JS_Variant *variant);
> ewk_js_meta_class_property_default_cb_set(Ewk_JS_Class_Meta *meta_cls, const char* name, Ewk_JS_Set_Cb set, Ewk_JS_Get_Cb get, Ewk_JS_Del_Cb del)
> ewk_js_meta_class_properties_default_cb_set(Ewk_JS_Class_Meta *meta_cls, Ewk_JS_Set_Cb set, Ewk_JS_Get_Cb get, Ewk_JS_Del_Cb del);
> 
> b) Adding a new function to create a Ewk_JS_Variant object. This function will initialize it to an empty value. 
> 
> c) Adding a new function to get value of property form object like this:
> Ewk_JS_Property *ewk_js_object_property_value_get(Ewk_JS_Object *object, const char *name)
>
> d) Remove:
> EAPI Eina_Hash *ewk_js_object_properties_get(const Ewk_JS_Object *obj);
> EAPI void ewk_js_variant_array_free(Ewk_JS_Variant *var, int count);

This could all be replaced with Eina_Model (even if Eina_Model itself needs some new code for that).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.