[Webkit-unassigned] [Bug 77337] [EFL] Refactor ewk_js files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77337





--- Comment #7 from Tomasz Morawski <t.morawski at samsung.com>  2012-02-09 00:12:30 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > Is it really that bad to rewrite everything?
> 
> IMO, yes. Besides the code having no useful documentation, there are a lot of style issues such as the ones you are trying to clean up (plus a lot of useless C-isms and manual memory management), similar functions with different order of parameters and bad architecture in general (external code shouldn't be able to access so many structures and their fields directly, ewk_js_npobject_to_object duplicates the Ewk_JS_Object creation code etc).

I have made a simple test code and now I see why would you like to make bigger clean up of this API. Due to that I have decided to abondon my patch. I started to make complex refactor of js files with mentioned architecture changes, general clean up and partial reimplementation of internal functions. Manual memory managment will be also removed. I will also try to make some comments inside code and prepare complex code including related html page. I think I will able to show a first version of patch soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.