[Webkit-unassigned] [Bug 78194] ASSERT_NO_EXCEPTION should be initialized with non-zero value.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 8 21:24:56 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=78194





--- Comment #5 from Shinya Kawanaka <shinyak at chromium.org>  2012-02-08 21:24:56 PST ---
(In reply to comment #4)
> (From update of attachment 126232 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=126232&action=review
> 
> Thanks for taking this. Our current version is error prone...
> 
> > Source/WebCore/dom/ExceptionCodePlaceholder.h:44
> > +    ExceptionCodePlaceholder() : m_code(defaultExceptionCode) { }
> 
> Please do this for NoExceptionAssertionChecker to keep ExceptionCodePlacerHolder code-free.

Ya, this code seems wrong, because NoExceptionAssertionChecker initializes ExceptionCode with zero.
We should change this value... Let me try again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list