[Webkit-unassigned] [Bug 77935] Disable adding a shadow root to elements having a dynamic built-in shadow root.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 8 09:19:46 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77935


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125779|review?                     |review-
               Flag|                            |




--- Comment #4 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-02-08 09:19:46 PST ---
(From update of attachment 125779)
View in context: https://bugs.webkit.org/attachment.cgi?id=125779&action=review

>> Source/WebCore/dom/ShadowRoot.h:49
>> +    enum CheckUserShadowRootAllowance {
> 
> It might be better to rename this to reflect the caller intent, eg
> 
> enum (mumble) {
>   CreatingUserAgentShadowRoot,
>   CreatingAuthorShadowRoot
> }
> 
> ?

I like Dominic's idea here. Other than that, the patch looks fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list