[Webkit-unassigned] [Bug 77864] [Qt] Initial implementation of accessibility support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77864





--- Comment #19 from Simon Hausmann <hausmann at webkit.org>  2012-02-08 04:38:23 PST ---
(From update of attachment 125837)
One thing I'm a bit uneasy about now is the ownership.

AccessibilityObject is refcounted and it seems that on mac/win/chromium the AccessibilityObject also keeps a strong reference on the wrapper object.

This pattern is completely ignored right now, the Qt version of AccessibilityObjectWrapper keeps a raw pointer to the AccessibilityObject, which means it can become dangling at any time.

WTF::RefCounted does not support weak pointers, but there's the AXObjectCache along with the objects having AXIDs. Is this perhaps what we should be using instead?

So that our implementation of QAccessibleInterface* - which btw should probably live in WebKit/qt/WebCoreSupport - stores a weak pointer to the QWebPage as well as the AXID. Then when we need an AccessibilityObject we can look it up from the document's AXObjectCache through the ID.

Does that make sense?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.