[Webkit-unassigned] [Bug 27160] Implement vw/vh/vm (viewport sizes) from CSS 3 Values and Units

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27160





--- Comment #26 from Luke Macpherson <macpherson at chromium.org>  2012-02-08 03:29:48 PST ---
(From update of attachment 126010)
View in context: https://bugs.webkit.org/attachment.cgi?id=126010&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:2379
> +static Length convertToLength(CSSPrimitiveValue* primitiveValue, CSSStyleSelector* styleSelector, bool toFloat, double multiplier = 1, bool *ok = 0)

This code should no longer be static, and should instead be a member function of CSSStyleSelector.

> Source/WebCore/css/CSSStyleSelector.cpp:2411
> +static Length convertToIntLength(CSSPrimitiveValue* primitiveValue, CSSStyleSelector* styleSelector, double multiplier = 1, bool *ok = 0)

This code should no longer be static, and should instead be a member function of CSSStyleSelector.

> Source/WebCore/css/CSSStyleSelector.cpp:2416
> +static Length convertToFloatLength(CSSPrimitiveValue* primitiveValue, CSSStyleSelector* styleSelector, double multiplier = 1, bool *ok = 0)

This code should no longer be static, and should instead be a member function of CSSStyleSelector.

> Source/WebCore/css/CSSStyleSelector.cpp:5692
> +Length RelativeviewportLength(CSSPrimitiveValue* primitiveValue, Document* document)

This code almost certainly belongs in CSSPrimitiveValue::computeLength.

> Source/WebCore/css/CSSStyleSelector.h:479
> +Length RelativeviewportLength(CSSPrimitiveValue*, Document*);

captialization

> Source/WebCore/platform/Length.h:248
> +    RelativeViewportLengthType relativeViewportLengthType() const { return static_cast<RelativeViewportLengthType>(m_viewportLengthType); }

I would like to s/RelativeViewport/ViewportRelative throughout this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.