[Webkit-unassigned] [Bug 77938] SVGTRefElement shouldn't dynamically create a shadow root.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77938


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #126005|review?                     |review-
               Flag|                            |




--- Comment #3 from Nikolas Zimmermann <zimmermann at kde.org>  2012-02-08 01:46:46 PST ---
(From update of attachment 126005)
View in context: https://bugs.webkit.org/attachment.cgi?id=126005&action=review

r- for the missing tests for now. Patch looks good in general.

> Source/WebCore/ChangeLog:9
> +        SVGTRefElement creates a shadow root dynamically. This will cause a problem to support
> +        multiple shadow subtrees. So it should be created in a constructor phase.
> +
> +        Reviewed by NOBODY (OOPS!).

These blocks should be swapped.
Can you include a testcase that shows this problem? Otherwise this will break again in future.

> Source/WebCore/svg/SVGTRefElement.cpp:61
> -    return adoptRef(new SVGTRefElement(tagName, document));
> +    RefPtr<SVGTRefElement> elem = adoptRef(new SVGTRefElement(tagName, document));
> +    elem->createShadowSubtree();
> +    return elem.release();

s/elem/element/ - no abbreviations please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.