[Webkit-unassigned] [Bug 77886] KeywordLookupGenerator.py script fails in some cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 21:35:54 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77886





--- Comment #10 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-02-07 21:35:53 PST ---
(In reply to comment #9)
> > Fair enough. However, I'd like to avoid accidental mistakes as much as possible. I see 3 possible solutions:
> > 
> > 1) Force LF only via tests and convert the input file.
> 
> Yep, you can do that with check-webkit-style. Optionally you can add support for converting automatically the input file through webkit-patch.

Great. I'll make the appropriate changes in at least check-webkit-style and possibly auto-convert in webkit-patch and resubmit.

> 
> > Of course we can always manually fix the input file, until it fails again on someone... or pick on of the above (or another suggestion?)
> 
> Given no port nor bot require support for this, I think Darin has a fair point about not supporting CRLF here.

Sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list