[Webkit-unassigned] [Bug 77886] KeywordLookupGenerator.py script fails in some cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 20:23:11 PST 2012


--- Comment #8 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-02-07 20:23:10 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > line breaks aren't predictable
> Maybe true for the programming world at large, but need not be true for the WebKit project. We can make whatever rule we like about line breaks. There is no good reason for us to support CR or CRLF line breaks in project tools; we should consistently set properties so our source files all use LF line breaks except for the small number of files that may be subject to specific platform requirements on Windows that might require something different.
> > After all, we *can* have lines with CR breaks only.
> Not a goal for the project.

Fair enough. However, I'd like to avoid accidental mistakes as much as possible. I see 3 possible solutions:

1) Force LF only via tests and convert the input file.
2) Force LF only on the input file via a commit-time hook (git would make that a breeze, alas).
3) Accept my patch which by only adding one line supports the current input file as-is.

I don't know whether or not we have tests for build scripts and specifically for KeywordLookupGenerator.py. Any tips are welcome.
I don't know how to add SVN commit-time hooks on the client.
I've submitted a working patch as the third alternative.

Of course we can always manually fix the input file, until it fails again on someone... or pick on of the above (or another suggestion?)

Let me know what's the preferred action in a similar case for WebKit.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list