[Webkit-unassigned] [Bug 78049] [BlackBerry] Upstream BlackBerry WebCoreSupport FrameNetworkingContextBlackBerry and IconDatabaseClientBlackBerry classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78049


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125946|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-02-07 15:52:40 PST ---
(From update of attachment 125946)
View in context: https://bugs.webkit.org/attachment.cgi?id=125946&action=review

Some small nits.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:32
> +        instance = new IconDatabaseClientBlackBerry();

Can you use DEFINE_STATIC_LOCAL?

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.cpp:60
> +    return (m_initState == InitializeSucceeded);

No need for parentheses.

> Source/WebKit/blackberry/WebCoreSupport/IconDatabaseClientBlackBerry.h:40
> +public:

Better move the public section up above the private, this is the standard.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.