[Webkit-unassigned] [Bug 78028] Not For Review: Decouple scrollbar painting from Scrollbar object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78028


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-02-07 13:31:51 PST ---
Attachment 125913 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Source/WebCore/platform/chromium/ScrollbarThemePainterChromiumLinux.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromiumLinux.h:50:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/WebCore.gypi:2950:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/WebCore.gypi:2951:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/WebCore.gypi:2952:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/WebCore.gypi:2953:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromium.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromium.h:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromium.h:46:  More than one command on the same line  [whitespace/newline] [4]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromium.h:53:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromium.h:68:  The parameter name "scrollbar" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromium.h:69:  The parameter name "scrollbar" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/chromium/ScrollbarThemePainterChromiumLinux.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/chromium/ScrollbarPaintData.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/chromium/ScrollbarPaintData.cpp:41:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/chromium/ScrollbarThemeChromium.h:44:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/chromium/ScrollbarPaintData.h:29:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
Source/WebCore/platform/chromium/ScrollbarPaintData.h:42:  The parameter name "orientation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/chromium/ScrollbarPaintData.h:42:  The parameter name "controlSize" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 19 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.