[Webkit-unassigned] [Bug 63451] Embedded widgets are not drawn

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63451


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125816|                            |review-
               Flag|                            |




--- Comment #7 from Martin Robinson <mrobinson at webkit.org>  2012-02-07 10:54:40 PST ---
(From update of attachment 125816)
View in context: https://bugs.webkit.org/attachment.cgi?id=125816&action=review

Great work! If you attach a proper ChangeLog to this patch and fix the nits below, we can commit it directly from the bug. See http://www.webkit.org/coding/contributing.html. I think you can skip writing tests for this change...just delete that line from the ChangeLog.

Do you mind testing what happens when you remove the contents of the GtkPluginWidget::paint method entirely? If the real expose event is drawing the child widgets, perhaps we don't have to make fake expose events at all.

> Source/WebCore/platform/gtk/GtkPluginWidget.cpp:49
> +    GtkWidget *parent;
> +
> +    parent = gtk_widget_get_parent(platformWidget());
> +    gtk_container_remove(GTK_CONTAINER(parent), platformWidget());

This should just be one line:

gtk_container_remove(GTK_CONTAINER(gtk_widget_get_praent(platformWidget()), platformWidget());

>> Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:486
>> +        gtk_container_add (GTK_CONTAINER (getViewFromFrame(m_frame)), gtkWidget);
> 
> Extra space before ( in function call  [whitespace/parens] [4]

Please fix the style issue here.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:664
> +    /* Force child widgets to be drawn as last */

Might want to expand this comment a bit:

// Chaining up to the parent forces child widgets to be drawn.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.