[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77509





--- Comment #19 from Raymond Toy <rtoy at chromium.org>  2012-02-07 09:08:18 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > Created an attachment (id=125775)
 --> (https://bugs.webkit.org/attachment.cgi?id=125775&action=review) [details] [details]
> > Patch
> 
> Hi Ray and Chris, patch is updated as comments but I met an issue when running the biquad-*.html layout tests.
> 
> For my new patch, I could pass the every biquad-*.html test by running them separately but not when running them together. 
> Like run-webkit-tests webaudio and run-webkit-tests biquad*, it sometimes failed.

I had this problem on Windows.  I think it was fixed when I recompiled DumpRenderTree.

But I will look into this some more on my system (but without IPP.)
> 
> I tried to adjust the value of 'timeStep' in biquad-testing.js as the comments, but it did not work. I could not figure out the problem in patch or in the test scripts, could you provide some help on this?  Thanks a lot.

What did you change timeStep to?  And in what way did it not work?

> 
> Some details:
> 
> xingnan at xingnan-pc:~/Workspace/chromium/src/third_party/WebKit$ ./Tools/Scripts/run-webkit-tests webaudio  webaudio/biquad-lowshelf.html -> unexpected text diff mismatch
> 
> Retrying 1 unexpected failure(s) ...
> 
> 33 tests ran as expected, 1 didn't:                 
> 
> 
> Unexpected flakiness: text diff mismatch (1)
>   webaudio/biquad-lowshelf.html = TEXT PASS
> 
> Tests Biquad lowshelf filter.
> 
> On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> 
> PASS
> 
> FAIL Rendered output did not have has 831 infinities or NaNs.

Oops.  A typo got into the message and no one noticed.  Could you update your patch to fix this to read "output has 831 infinities..."?

> PASS
> FAIL Lowshelf filter response is correct.

Oops.  That should be "is not correct".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.