[Webkit-unassigned] [Bug 77943] REGRESSION (r106899): broke multiple tests on GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77943





--- Comment #3 from Zalan Bujtas <zbujtas at gmail.com>  2012-02-07 06:23:13 PST ---
> It still would need to be done before we are starting to layout.
Agree. Layout is forced on the view, soon after the cached frame is all set with the restore. See at FrameLoader::commitProvisionalLoad().
The following change could work, where updateViewportArguments() is moved to Document::documentDidResumeFromPageCache() callback.


Index: Source/WebCore/dom/Document.cpp
===================================================================
--- Source/WebCore/dom/Document.cpp    (revision 106913)
+++ Source/WebCore/dom/Document.cpp    (working copy)
@@ -4078,8 +4078,6 @@
         setRenderer(m_savedRenderer);
         m_savedRenderer = 0;

-        updateViewportArguments();
-
         if (childNeedsStyleRecalc())
             scheduleStyleRecalc();
     }
@@ -4120,6 +4118,8 @@

     ASSERT(m_frame);
     m_frame->loader()->client()->dispatchDidBecomeFrameset(isFrameSet());
+
+    updateViewportArguments();
 }

 void Document::registerForPageCacheSuspensionCallbacks(Element* e)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.