[Webkit-unassigned] [Bug 77878] [gtk] Accessibility: use find funtion in vector instead of for.

Tue Feb 7 05:37:41 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=77878

Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org,
                   |                            |pnormand at igalia.com

--- Comment #5 from Mario Sanchez Prada <msanchez at igalia.com>  2012-02-07 05:37:41 PST ---
(In reply to comment #4)
> [...]
> It's your code ;) I just thought it might be nice to have it a little easier to read. I personally would prefer the
> one liner, but I guess that's a matter of taste. 

Actually it is not :-). That code comes from the former, old and big, AccessibilityObjectWrapperAtk.cpp file that we used to have prior to the refactoring, and that specific implementation is not mind, IIRC, so that's why it got into this new file without me noticing.

In any case, I appreciate very much this refactoring since it's definitely easier to read, but still I personally think it would be better to explicitly consider this WTF:notFound value, as it's done in other places, such as AccessibilityObject.cpp.

> Also mind that I didn't compile it since I don't even have the dependencies to build the gtk port.

Well, the EWS says it's building fine, and the change seems to be pretty harmless :-)

Anyway, I'm not a reviewer yet, so I'm CCing people who is to see if we can get this in.

Thank you!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.