[Webkit-unassigned] [Bug 76171] [WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 7 00:32:42 PST 2012


Tomasz Morawski <t.morawski at samsung.com> changed:

           What    |Removed                     |Added
                 CC|                            |t.morawski at samsung.com

--- Comment #16 from Tomasz Morawski <t.morawski at samsung.com>  2012-02-07 00:32:42 PST ---
(In reply to comment #15)
> (In reply to comment #12)
> > > Source/WebKit2/WebProcess/Downloads/efl/FileDownloaderEfl.h:53
> > > +    virtual void didReceiveData(WebCore::ResourceHandle*, const char*, int, int /*encodedDataLength*/);
> > 
> > WebKit convention is to give argument variable names if the purpose of variables aren't self-evident as they're case for const char*, int, and int here
> > instead of adding inline comment like this for annotation purposes.
> Rniwa, I'm sorry for missing this nit. I won't miss similar nits in next time.

Please make ~FileDownloaderEfl() destructor virtual.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list