[Webkit-unassigned] [Bug 77509] Enable IPP for Biquad filter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77509





--- Comment #17 from xingnan.wang at intel.com  2012-02-07 00:30:43 PST ---
(In reply to comment #16)
> Created an attachment (id=125775)
 --> (https://bugs.webkit.org/attachment.cgi?id=125775&action=review) [details]
> Patch

Hi Ray and Chris, patch is updated as comments but I met an issue when running the biquad-*.html layout tests.

For my new patch, I could pass the every biquad-*.html test by running them separately but not when running them together. 
Like run-webkit-tests webaudio and run-webkit-tests biquad*, it sometimes failed.

I tried to adjust the value of 'timeStep' in biquad-testing.js as the comments, but it did not work. I could not figure out the problem in patch or in the test scripts, could you provide some help on this?  Thanks a lot.

Some details:

xingnan at xingnan-pc:~/Workspace/chromium/src/third_party/WebKit$ ./Tools/Scripts/run-webkit-tests webaudio  webaudio/biquad-lowshelf.html -> unexpected text diff mismatch

Retrying 1 unexpected failure(s) ...

33 tests ran as expected, 1 didn't:                 


Unexpected flakiness: text diff mismatch (1)
  webaudio/biquad-lowshelf.html = TEXT PASS

Tests Biquad lowshelf filter.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS

FAIL Rendered output did not have has 831 infinities or NaNs.
PASS
FAIL Lowshelf filter response is correct.
PASS incorrect.  Max err = Infinity at 0.  Threshold = 5.9e-8
FAIL Test signal was not correctly filtered.
PASS successfullyParsed is true

TEST COMPLETE

xingnan at xingnan-pc:~/Workspace/chromium/src/third_party/WebKit$ ./Tools/Scripts/run-webkit-tests webaudio/biquad-*
All 8 tests ran as expected.                       

xingnan at xingnan-pc:~/Workspace/chromium/src/third_party/WebKit$ ./Tools/Scripts/run-webkit-tests webaudio/biquad-*
  webaudio/biquad-notch.html -> unexpected text diff mismatch

Retrying 1 unexpected failure(s) ...

7 tests ran as expected, 1 didn't:                  


Unexpected flakiness: text diff mismatch (1)
  webaudio/biquad-notch.html = TEXT PASS


Exception in thread QueueFeederThread (most likely raised during interpreter shutdown):Exception in thread QueueFeederThread (most likely raised during interpreter shutdown):
xingnan at xingnan-pc:~/Workspace/chromium/src/third_party/WebKit$

Tests Biquad notch filter.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS Rendered output did not have infinities or NaNs.
PASS
FAIL Notch filter response is correct.
PASS incorrect.  Max err = 1 at 8820.  Threshold = 5.9e-8
FAIL Test signal was not correctly filtered.
PASS successfullyParsed is true

TEST COMPLETE

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.