[Webkit-unassigned] [Bug 76171] [WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 22:56:40 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76171





--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2012-02-06 22:56:39 PST ---
(From update of attachment 125764)
View in context: https://bugs.webkit.org/attachment.cgi?id=125764&action=review

> Source/WebKit2/ChangeLog:7
> +        It communicates with Download class to be ordered to start download

Nit: you can omit "to be ordered"

> Source/WebKit2/ChangeLog:10
> +        Besides FileDownloaderEfl is a derived class from ResourceHandleClient.
> +        So, it can receive chunked data from ResourceHandle directly

You can just say "FileDownloaderEfl derives from ResourceHandleClient and recieves chunked data"...

> Source/WebKit2/ChangeLog:17
> +        Reviewed by NOBODY (OOPS!).

This line should appear before the long description.

> Source/WebKit2/WebProcess/Downloads/efl/FileDownloaderEfl.h:53
> +    virtual void didReceiveData(WebCore::ResourceHandle*, const char*, int, int /*encodedDataLength*/);

WebKit convention is to give argument variable names if the purpose of variables aren't self-evident as they're case for const char*, int, and int here
instead of adding inline comment like this for annotation purposes.

> Source/WebKit2/WebProcess/Downloads/efl/FileDownloaderEfl.h:54
> +    virtual void didFinishLoading(WebCore::ResourceHandle*, double /*finishTime*/);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list