[Webkit-unassigned] [Bug 77926] [Blackberry] Clean up Networkjob and Networkmanger: remove unused variables and change some public functions into be private ones

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 22:18:15 PST 2012


--- Comment #11 from Chris.Guan <chris.guan at torchmobile.com.cn>  2012-02-06 22:18:15 PST ---
(In reply to comment #10)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Why remove m_isRunning and the ASSERT? What about guard it with #ifndef NDEBUG macro so that m_isRunning and NetworkJob::isRunning() are there only for Debug mode.
> > 
> > No, it dose not make any help, because the code log makes sure this assert is never hit, because the delete timer is firing after handleNotifyClose() in which
> > definitely m_isRunning was set to false. I added this comments in my change log in the patch:)
> ASSERT is designed for never being hit. We ASSERT(!job->isRunning()) to make sure we don't delete a job on which handleNotifyClose() never be called. If you remove this ASSERT, we can't catch the code offending this assumption any more.

yes, you are right, but deleteJob() is a private function of NetworkManger, and only the friend class of networkjob can use it, actually it is deleteTimer. refactor?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list