[Webkit-unassigned] [Bug 77886] KeywordLookupGenerator.py script fails in some cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 21:51:47 PST 2012


--- Comment #6 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-02-06 21:51:46 PST ---
(In reply to comment #3)
> (From update of attachment 125688 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125688&action=review
> This whole split cascade is a bit odd.  Is this file not unittested?  Normally we test all changes in WebKit, including python changes.

Agreed on the odd part, but considering that line breaks aren't predictable, we either have to remove carriage-returns (before or after splitting) or we have to be more generic and break at CR as well as LF. After all, we *can* have lines with CR breaks only.

> > Source/JavaScriptCore/ChangeLog:8
> > +        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
> Looks like you didn't actually change this file.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list