[Webkit-unassigned] [Bug 76171] [WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 6 20:20:18 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76171
--- Comment #9 from Gyuyoung Kim <gyuyoung.kim at samsung.com> 2012-02-06 20:20:18 PST ---
(From update of attachment 124256)
View in context: https://bugs.webkit.org/attachment.cgi?id=124256&action=review
It seems to me FileDownloaderEfl is more proper name. Almost files add port name as postfix.
> Source/WebKit2/WebProcess/Downloads/Download.h:158
> + OwnPtr<EflFileDownloader> m_eflFileDownloader;
You already use #if PLATFORM(EFL). So, IMHO, you don't need to add efl prefix to variable name. I don't see port name prefix from now except for m_qtDownloader.
m_eflFileDownloader -> m_fileDownloader;
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list