[Webkit-unassigned] [Bug 77905] Change baselinePosition and lineHeight to LayoutUnit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 17:53:20 PST 2012


--- Comment #2 from Eric Seidel <eric at webkit.org>  2012-02-06 17:53:20 PST ---
(From update of attachment 125720)
View in context: https://bugs.webkit.org/attachment.cgi?id=125720&action=review

> Source/WebCore/ChangeLog:9
> +        Change the virtual baselinePosition and lineHeight methods to use
> +        LayoutUnits in preparation for the switch over to subpixel layout.

It would be better to explain why these functions should be using these types in the Changelog.  You don't have to detail each one, but a setence like:

RenderTheme deals only with rendering objects, which will be positioned by LayoutUnit coordinates.

or something like that.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list