[Webkit-unassigned] [Bug 76720] [chromium] Refactor video drawing to be more data driven

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 14:15:43 PST 2012


--- Comment #27 from Adrienne Walker <enne at google.com>  2012-02-06 14:15:43 PST ---
(From update of attachment 125331)
View in context: https://bugs.webkit.org/attachment.cgi?id=125331&action=review

Other than the one below comment, this looks good to me.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:191
> -void CCLayerTreeHostImpl::calculateRenderPasses(CCRenderPassList& passes)
> +PassOwnPtr<CCLayerTreeHostImpl::CCLayerList> CCLayerTreeHostImpl::calculateRenderPasses(CCRenderPassList& passes)

style nit: It's weird to have this function return one value as a return value and another value by modifying a reference.  I kind of feel like the caller should create the CCLayerList on the stack and pass that in as a reference along with CCRenderPassList.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list