[Webkit-unassigned] [Bug 19681] borderColor on table elements should be ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19681





--- Comment #8 from Robert Hogan <robert at webkit.org>  2012-02-06 12:57:28 PST ---
(From update of attachment 125623)
View in context: https://bugs.webkit.org/attachment.cgi?id=125623&action=review

Change looks ok - but the tests need updating - you should use reference tests as I describe in my inline comment.

> LayoutTests/platform/win/fast/table/table-ignore-bordercolor-when-noborder-expected.txt:1
> +FAIL: Timed out waiting for notifyDone to be called

You can just drop the LayoutTestController stuff from the test, it's not necessary.

Create a LayoutTests/fast/table/table-ignore-bordercolor-when-noborder-expected.html as your expected result. run-webkit-tests will run table-ignore-bordercolor-when-noborder.html and table-ignore-bordercolor-when-noborder-expected.html and make sure they render the same. Naturally table-ignore-bordercolor-when-noborder-expected.html should not use the borderColor attribute to achieve the same result!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.