[Webkit-unassigned] [Bug 77873] check-webkit-style failing with "Path does not exist."

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77873


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |dpranke at chromium.org
                   |kit.org                     |
     Ever Confirmed|0                           |1




--- Comment #4 from Dirk Pranke <dpranke at chromium.org>  2012-02-06 12:23:00 PST ---
(In reply to comment #2)
> At a quick glance, it looks like the problem is that it's not correctly mapping the "win" in the test_expectations.txt path to a port. The "test" port is the fallback port when the port can't be identified. IIRC, Dirk already has a patch somewhere fixing this, but I don't know what the status of it is.

Hm. I think Ojan might be referring to bug 76745, which is a bit different (at least, that's the only  patch I've worked on that is ringing a bell for me).

That said, fixing this is straightforward. The mapping from LayoutTests/platform/$name to port is loose at best; the code in lines 74-81 is wrong and what we should do is fetch all of the ports using PortFactory.all_port_names() and then grep the list until you find one whose path_to_test_expectations_file() matches.

I will upload a patch for this shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.