[Webkit-unassigned] [Bug 75522] Enable IPP for FFTFrame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 10:47:06 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=75522





--- Comment #39 from Tony Chang <tony at chromium.org>  2012-02-06 10:47:06 PST ---
(From update of attachment 125587)
View in context: https://bugs.webkit.org/attachment.cgi?id=125587&action=review

> Source/WebCore/platform/audio/ipp/FFTFrameIPP.cpp:44
> +const unsigned kMaxFFTPow2Size = 24;

Nit: We normally just use regular variable naming for consts in WebCore.  E.g., maximumFFTPower2Size.

> Source/WebCore/platform/audio/ipp/FFTFrameIPP.cpp:85
> +    unsigned nbytes = sizeof(float) * m_FFTSize;

Nit: We try to avoid abbreviations in variable names. Maybe numberOfBytes or byteSize?

> Source/WebCore/platform/audio/ipp/FFTFrameIPP.cpp:139
> +    ippsDFTFwd_RToPerm_32f((Ipp32f*)data, complexP, m_DFTSpec, m_buffer);

Nit: reinterpret_cast?

> Source/WebCore/platform/audio/ipp/FFTFrameIPP.cpp:147
> +    ippsCplxToReal_32fc((Ipp32fc*)complexP, realP, imagP, m_FFTSize >> 1);

Nit: reinterpret_cast?

> Source/WebCore/platform/audio/ipp/FFTFrameIPP.cpp:155
> +    ippsDFTInv_PermToR_32f(complexP, (Ipp32f*)data, m_DFTSpec, m_buffer);

Nit: reinterpret_cast?

> Source/WebCore/platform/audio/ipp/FFTFrameIPP.cpp:160
> +    ippsMulC_32f_I(scale, (Ipp32f*)data, m_FFTSize);

Nit: reinterpret_cast?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list