[Webkit-unassigned] [Bug 76779] [BlackBerry]Use extension for a mimetype as the suggested extension if the url file doesn't have an extension.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76779





--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-02-06 05:45:44 PST ---
(From update of attachment 125606)
View in context: https://bugs.webkit.org/attachment.cgi?id=125606&action=review

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:614
> +    // fill it in from the url and sniffed mime type;Skip this for data and about URLs,

the Skip section seems untidy. Needs a space and no need for capital S.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625
> +                    suggestedFilename = String("Untitled") + "." + mimeExtension;

This could be done differently:
suggestedFilename = String("Untitled");
if (!mimeExtension.isEmpty()) // No extension found for the mimeType.
    suggestedFilename = "." + mimeExtension;

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:630
> +                   suggestedFilename = urlFilename;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.