[Webkit-unassigned] [Bug 77864] [Qt] Initial implementation of accessibility support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 04:35:58 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77864


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-02-06 04:35:58 PST ---
Attachment 125614 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1

Source/WebKit/qt/Api/qwebviewaccessible.cpp:21:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/accessibility/qt/AccessibilityObjectWrapper.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebview.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/qt/Api/qwebviewaccessible_p.h:20:  #ifndef header guard has wrong style, please use: qwebviewaccessible_p_h  [build/header_guard] [5]
Source/WebKit/qt/Api/qwebviewaccessible_p.h:38:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/accessibility/qt/AccessibilityObjectWrapper.h:49:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/accessibility/qt/AccessibilityObjectWrapper.h:61:  The parameter name "relation" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/accessibility/qt/AccessibilityObjectWrapper.h:74:  The parameter name "t" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/accessibility/AccessibilityObject.h:49:  "AccessibilityObjectWrapper.h" already included at Source/WebCore/accessibility/AccessibilityObject.h:47  [build/include] [4]
Total errors found: 9 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list