[Webkit-unassigned] [Bug 77551] [GTK] Fix xrefs after installing API documentation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 6 00:52:15 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77551





--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-02-06 00:52:14 PST ---
(In reply to comment #9)
> (From update of attachment 124957 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124957&action=review
> 
> >>> Tools/GNUmakefile.am:328
> >>> +	$(srcdir)/Tools/gtk/generate-gtkdoc --rebase
> >> 
> >> I think this should happen automatically when --skip-html is not passed to generate-gtkdoc. Either that or you should add --skip-rebase to generate-gtkdoc and make sure to pass it in the build scripts.
> > 
> > I'm not sure I get what you mean, you only want to rebase installed docs, so rebase has to be called once the docs has been installed.
> 
> Ah, I understand now. I suggested a small rename below then.
> 
> >>> Tools/gtk/generate-gtkdoc:140
> >>> +        rebase_doc(pkg_config_path, get_webkit1_options(common.gtk_version(pkg_config_path)))
> >> 
> >> I think it makes sense to just get the options once here.
> > 
> > it happens once
> 
> Sorry, I meant just to factor out the code that gets the options to one place.
> options = get_webkit1_options(common.gtk_version(pkg_config_path)
> if '--rebase' not in sys.argv:
>     print "Generating WebKit1 documentation..."
>     saw_webkit1_warnings = generate_doc(pkg_config_path, options)
> else:
>     print "Rebasing WebKit1 documentation..."
>     rebase_doc(pkg_config_path, options)

Ok

> > Tools/gtk/gtkdoc.py:352
> > +    def rebase(self):
> 
> Perhaps call this rebase_installed_docs, just to avoid confusing dumb people like me. :)

Ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list