[Webkit-unassigned] [Bug 75522] Enable IPP for FFTFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75522





--- Comment #36 from xingnan.wang at intel.com  2012-02-06 00:39:33 PST ---
(In reply to comment #33)
> (From update of attachment 125242 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125242&action=review
> 
> Just some small nits left. Otherwise, the gyp changes look good to me.
> 
> Chris, do the code changes look good to you?
> 
> > Source/WebCore/WebCore.gyp/WebCore.gyp:2001
> > +          'all_dependent_settings': {
> 
> I don't think you need all_dependent_settings here.  I think gyp is smart enough to copy link_settings down to the targets that need it.
> 
> > Source/WebCore/WebCore.gyp/WebCore.gyp:2004
> > +            'ldflags': [
> > +              '<!@(pkg-config --libs-only-L ipp)',
> > +            ],
> 
> Doesn't this have to go in link_settings?  That's what I see for other uses of ldflags.  See Source/WebKit/chromium/build/linux/system.gyp for other examples.

Agree, update the patch as your comments.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.