[Webkit-unassigned] [Bug 77610] Introduces BuiltinShadowRoot and methods.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77610





--- Comment #4 from Dominic Cooney <dominicc at chromium.org>  2012-02-05 23:29:23 PST ---
(From update of attachment 125579)
View in context: https://bugs.webkit.org/attachment.cgi?id=125579&action=review

> Source/WebCore/ChangeLog:44
> +        (WebCore::ColorInputType::createShadowSubtree):

Would it be simpler to, instead of introducing a new BuiltinShadowRoot type and new methods for built-in shadows, to just have elements which have built-in shadows like *InputType, HTMLDetailsElement, HTMLKeygenElement, HTMLMediaElement, HTMLTextAreaElement, etc. have a member that points to its built-in shadow root? It avoids the virtual method call, avoids new API, avoids a new type, etc.

You can leave the shadow root mechanism to manage the refcount of the built-in shadow root, since there is no way to remove them, and just use a raw pointer to the built-in shadow root.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.