[Webkit-unassigned] [Bug 77797] DFG's child references from one node to another should have room for type information

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77797





--- Comment #11 from Oliver Hunt <oliver at apple.com>  2012-02-05 17:08:59 PST ---
(From update of attachment 125538)
View in context: https://bugs.webkit.org/attachment.cgi?id=125538&action=review

Other than the comments included (below?) this looks fairly sensible to me.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:173
> -                    nodeIndex = addToGraph(GetLocal, OpInfo(variableAccessData), nodePtr->child1());
> +                    nodeIndex = addToGraph(GetLocal, OpInfo(variableAccessData), nodePtr->child1().index());

It seems like it would be nicer to make addToGraph take a Node/NodeUse rather than a NodeIndex, which would remove some of the churn in this diff.

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2273
> +                phiNode->children.child1() = NodeUse(valueInPredecessor);

I'd prefer setChild1(..) to returning a mutable reference.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.