[Webkit-unassigned] [Bug 77751] [BlackBerry] Upstream BlackBerry WebCoreSupport ClientExtension and GeolocationControllerClientBlackBerry classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77751


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125393|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2012-02-03 14:24:35 PST ---
(From update of attachment 125393)
View in context: https://bugs.webkit.org/attachment.cgi?id=125393&action=review

This is almost perfect, just needs the early return style.

> Source/WebKit/blackberry/WebCoreSupport/ClientExtension.cpp:39
> +    JSValueRef jsRetVal = JSValueMakeUndefined(ctx);

This code should look better with early return if argumentCount <= 0, which is webkit style, can you do that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.