[Webkit-unassigned] [Bug 77541] SVG pixel tests can't catch regressions anymore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77541





--- Comment #3 from Nikolas Zimmermann <zimmermann at kde.org>  2012-02-03 13:32:57 PST ---
(In reply to comment #2)
> Could you describe what exactly you are trying to test with these? The pixel tests I'm familiar with in WebKit do one of two things:
> 
> 1.) Test that we render a given document correctly. This is done by setting up the document and then letting the test end. The -expected.png is just the final rendering of the page
> 
> 2.) Test that after rendering a given document A, we correctly repaint + render the document B which is A with some mutations applied. This is done by setting up document A, calling layoutTestController.display(), then mutating the document to state B and letting the test end.

It's all about (2). I'm fixing the first set of svg tests in bug 77736. We tried to fake (2) by using setTimeout(runTest, 0) hoping that painting would happen in-between. I changed that to call layoutTestController.display() to guarantee we're painting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.