[Webkit-unassigned] [Bug 77477] [chromium] Process scroll-gesture events from the MT compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77477





--- Comment #13 from James Robinson <jamesr at chromium.org>  2012-02-03 11:01:51 PST ---
(In reply to comment #11)
> (From update of attachment 125032 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=125032&action=review
> 
> >> Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp:155
> >> +        if (m_scrollStarted) {
> > 
> > i think we should ASSERT() on m_scrollStarted, not branch. if we get a scrollupdate without a scrollbegin it means that the caller has broken the contract with us - we should fail fast and loudly, not try to limp along IMO
> 
> Indeed. I am using m_expectedScrollUpdateEnd for precisely this purpose (e.g see lines 139, 154, 162). m_scrollStarted is used to make sure we don't call scrollBy or scrollEnd if the call to scrollBegin returned something other than ScrollStarted.
> 

Right. I'm saying you should NOT do this, you should just ASSERT().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.