[Webkit-unassigned] [Bug 77444] Web Inspector: CodeGeneratorInspector.py: switch domain agents to formal interfaces in BackendDispatcher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77444


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124984|review?                     |review-
               Flag|                            |




--- Comment #18 from Yury Semikhatsky <yurys at chromium.org>  2012-02-03 07:34:12 PST ---
(From update of attachment 124984)
View in context: https://bugs.webkit.org/attachment.cgi?id=124984&action=review

Looks good, but please add virtual to the methods that became virtual.

> Source/WebCore/inspector/InspectorCSSAgent.h:80
> +    void getMatchedStylesForNode(ErrorString*, int nodeId, const RefPtr<InspectorArray>* forcedPseudoClasses, const bool* includePseudo, const bool* includeInherited, RefPtr<InspectorArray>& matchedCSSRules, RefPtr<InspectorArray>& pseudoIdRules, RefPtr<InspectorArray>& inheritedEntries);

We usually keep virtual keywords for overridden virtual methods even though C++ doesn't require this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.