[Webkit-unassigned] [Bug 77726] Web Inspector: Retained size for classes is too conservative in heap profiler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77726


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #125296|review?                     |review+
               Flag|                            |




--- Comment #2 from Yury Semikhatsky <yurys at chromium.org>  2012-02-03 05:55:25 PST ---
(From update of attachment 125296)
View in context: https://bugs.webkit.org/attachment.cgi?id=125296&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:918
> +        function skip(node)

skip -> shouldSkip?

> Source/WebCore/inspector/front-end/HeapSnapshot.js:951
> +        var snapshot = this;

Just pass it as a parameter to forDominatedNodes.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:961
> +            var doms = snapshot._dominatedNodesOfNode(node);

doms -> dominatedNodeIndexes, we usually avoid abbreviations in the front-end code

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.