[Webkit-unassigned] [Bug 77308] [EFL] Enable WebGL with glx backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77308





--- Comment #21 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-02-02 21:24:26 PST ---
(From update of attachment 124747)
View in context: https://bugs.webkit.org/attachment.cgi?id=124747&action=review

Thank you all.

>>>> Source/WebCore/CMakeLists.txt:2209
>>>> +        platform/graphics/GraphicsContext3D.cpp
>>> 
>>> Why? It's not sorted anymore.
>> 
>> Sorry, I couldn't get the point. 'p' < 'r', right?
> 
> You need to take casing into account.

Excuse me, Could you tell me in detail? Do you want my explanation why I sorted files to build in ChangeLog? or Want to relocate GraphicsContext3D.cpp before DrawingBuffer.cpp?

>> Source/WebCore/platform/graphics/efl/DrawingBufferEfl.cpp:40
>> +                             bool separateBackingTexture)
> 
> In WebKit we usually keep parameter lists on one line.

Done.
But if you think DrawingBufferGtk.cpp is also needed to modify like this, let me know. :)

>> Source/WebCore/platform/graphics/efl/DrawingBufferEfl.cpp:66
>> +    // create a texture to render into
> 
> This comment should start with a capital letter and end with a period.

ditto.

>>>> Source/WebKit/efl/ewk/ewk_view.cpp:651
>>>> +    priv->pageSettings->setWebGLEnabled(true);
>>> 
>>> What happens if you pass true here but have ENABLE_WEBGL set to OFF (the default configuration)?
>> 
>> In that case, we can't create webgl context, so that we wouldn't see any webgl image.
> 
> So enabling WebGL in the source code even if WebGL is disabled in the build won't do any harm?

Right. No problem to build and run.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.